Code reviewHardcr-g496

Subject Error handlingLevel Senior–Staff~18 minCommon in Code quality & review interviewsIndustries Software development

Question

Review this Go function that writes a record to a file and closes it in a deferred call.

What a strong answer looks like

Separate real bugs from style. Rank issues by severity, point at the root cause rather than the symptom, and suggest a concrete fix — specific and kind.

Learn the concepts

Talk through your review

Code to reviewgo

1func writeRecord(path string, rec []byte) (err error) {2    f, err := os.Create(path)3    if err != nil {4        return err5    }6    defer func() {7        err = f.Close()8    }()9    if _, err := f.Write(rec); err != nil {10        return err11    }12    return nil13}

Run or narrate your approach, then ask the coach.