Partial failures silently ignored
Review this Go function that bulk-inserts events and reports the outcome to the caller.
What a strong answer looks like
Separate real bugs from style. Rank issues by severity, point at the root cause rather than the symptom, and suggest a concrete fix, specific and kind.
0:00 of about 16 min
Mark a line and say what kind of problem it is.0 findings
1func IngestBatch(events []Event) error {
2 var wg sync.WaitGroup
3 for _, e := range events {
4 wg.Add(1)
5 go func(ev Event) {
6 defer wg.Done()
7 _ = store.Insert(ev) // best effort
8 }(e)
9 }
10 wg.Wait()
11 return nil // batch accepted
12}
Which questions mattered is sealed until you submit. Telling you now would just be handing over the edge cases.
Run or narrate your approach, then ask the coach.