Code reviewMediumcr-g499

Subject Partial failureLevel Mid–Senior~16 minCommon in Code quality & review interviewsIndustries Software development, Technology

Question

Review this Go function that bulk-inserts events and reports the outcome to the caller.

What a strong answer looks like

Separate real bugs from style. Rank issues by severity, point at the root cause rather than the symptom, and suggest a concrete fix — specific and kind.

Learn the concepts

Talk through your review

Code to reviewgo

1func IngestBatch(events []Event) error {2    var wg sync.WaitGroup3    for _, e := range events {4        wg.Add(1)5        go func(ev Event) {6            defer wg.Done()7            _ = store.Insert(ev) // best effort8        }(e)9    }10    wg.Wait()11    return nil // batch accepted12}

Run or narrate your approach, then ask the coach.