Code reviewHardcr-g500

Subject Missing rollbackLevel Senior–Staff~20 minCommon in Databases & SQL · Reliability & on-call interviewsIndustries Software development, Technology

Question

Review this Java method that reserves inventory, then charges the card, and undoes the reservation if the charge fails.

What a strong answer looks like

Separate real bugs from style. Rank issues by severity, point at the root cause rather than the symptom, and suggest a concrete fix — specific and kind.

Learn the concepts

Talk through your review

Code to reviewjava

1public void purchase(Order o) {2    inventory.reserve(o.sku(), o.qty());3    try {4        payment.charge(o.card(), o.total());5    } catch (ChargeException e) {6        inventory.release(o.sku(), o.qty()); // compensate7        throw e;8    }9}

Run or narrate your approach, then ask the coach.