Code reviewMediumcr-g501

Subject Swallowed exceptionsLevel Mid–Senior~15 minCommon in Concurrency interviewsIndustries Software development

Question

Review this JavaScript code that persists each parsed row and is supposed to fail the import if any row fails.

What a strong answer looks like

Separate real bugs from style. Rank issues by severity, point at the root cause rather than the symptom, and suggest a concrete fix — specific and kind.

Learn the concepts

Talk through your review

Code to reviewjs

1async function importRows(rows) {2  rows.forEach(async (row) => {3    try {4      await db.insert(row);5    } catch (err) {6      throw new ImportError(row.id, err);7    }8  });9  return { imported: rows.length };10}

Run or narrate your approach, then ask the coach.