Code RoomAsync errors swallowed in forEach

MediumPrep Room Coding #2126

Async errors swallowed in forEach

Code reviewConcurrencyMid–Senior~15 min

Review this JavaScript code that persists each parsed row and is supposed to fail the import if any row fails.

What a strong answer looks like

Separate real bugs from style. Rank issues by severity, point at the root cause rather than the symptom, and suggest a concrete fix, specific and kind.

0:00 of about 15 min

Mark a line and say what kind of problem it is.0 findings

1async function importRows(rows) {

2 rows.forEach(async (row) => {

3 try {

4 await db.insert(row);

5 } catch (err) {

6 throw new ImportError(row.id, err);

7 }

8 });

9 return { imported: rows.length };

10}

Which questions mattered is sealed until you submit. Telling you now would just be handing over the edge cases.