Code reviewHardcr-g502

Subject Retry logicLevel Senior–Staff~18 minCommon in Networking & APIs interviewsIndustries Software development, Technology

Question

Review this Go helper that retries a transfer when the call returns any error, including timeouts.

What a strong answer looks like

Separate real bugs from style. Rank issues by severity, point at the root cause rather than the symptom, and suggest a concrete fix — specific and kind.

Learn the concepts

Talk through your review

Code to reviewgo

1func transfer(ctx context.Context, req TransferReq) error {2    var err error3    for i := 0; i < 3; i++ {4        err = bank.Transfer(ctx, req) // POST, no idempotency key5        if err == nil {6            return nil7        }8    }9    return err10}

Run or narrate your approach, then ask the coach.