Code reviewHardcr-g506

Subject Partial failureLevel Senior–Staff~18 minCommon in Code quality & review interviewsIndustries Software development, Technology

Question

Review this JavaScript code that provisions a new account across three downstream services.

What a strong answer looks like

Separate real bugs from style. Rank issues by severity, point at the root cause rather than the symptom, and suggest a concrete fix — specific and kind.

Learn the concepts

Talk through your review

Code to reviewjs

1async function provision(account) {2  await Promise.all([3    billing.createCustomer(account),4    auth.createUser(account),5    search.indexProfile(account),6  ]);7  return { ok: true };8}

Run or narrate your approach, then ask the coach.