Circuit breaker never resets
Review this Java breaker that opens after 5 failures and is supposed to protect a downstream.
What a strong answer looks like
Separate real bugs from style. Rank issues by severity, point at the root cause rather than the symptom, and suggest a concrete fix, specific and kind.
0:00 of about 18 min
Mark a line and say what kind of problem it is.0 findings
1class Breaker {
2 private int failures = 0;
3 <T> T call(Supplier<T> fn) {
4 if (failures >= 5) throw new BreakerOpenException();
5 try {
6 T r = fn.get();
7 return r; // success: counter untouched
8 } catch (RuntimeException e) {
9 failures++;
10 throw e;
11 }
12 }
13}
Which questions mattered is sealed until you submit. Telling you now would just be handing over the edge cases.
Run or narrate your approach, then ask the coach.