Code RoomDiscount parsing swallows errors

MediumPrep Room Coding #2133

Discount parsing swallows errors

Code reviewCode quality & reviewMid–Senior~14 min

Review this Python helper that parses an optional discount and applies it to a price.

What a strong answer looks like

Separate real bugs from style. Rank issues by severity, point at the root cause rather than the symptom, and suggest a concrete fix, specific and kind.

0:00 of about 14 min

Mark a line and say what kind of problem it is.0 findings

1def apply_discount(price, raw):

2 try:

3 pct = float(raw)

4 return price * (1 - pct / 100)

5 except Exception:

6 return price # no/invalid discount -> full price

Which questions mattered is sealed until you submit. Telling you now would just be handing over the edge cases.