Code reviewMediumcr-g508

Subject Swallowed exceptionsLevel Mid–Senior~14 minCommon in Code quality & review interviewsIndustries Software development

Question

Review this Python helper that parses an optional discount and applies it to a price.

What a strong answer looks like

Separate real bugs from style. Rank issues by severity, point at the root cause rather than the symptom, and suggest a concrete fix — specific and kind.

Learn the concepts

Talk through your review

Code to reviewpython

1def apply_discount(price, raw):2    try:3        pct = float(raw)4        return price * (1 - pct / 100)5    except Exception:6        return price  # no/invalid discount -> full price

Run or narrate your approach, then ask the coach.