Code Room
Code reviewMediumcr-g511
Subject Missing rollbackLevel Mid–Senior~16 minCommon in Reliability & on-call interviewsIndustries Software development

Question

Review this Python function that allocates a temp upload slot, writes parts, then finalizes.

What a strong answer looks like

Separate real bugs from style. Rank issues by severity, point at the root cause rather than the symptom, and suggest a concrete fix — specific and kind.

Talk through your review
Code to reviewpython
def upload(parts):    slot = storage.create_slot()      # reserves quota, returns handle    for p in parts:        if not p.valid():            return {"error": "bad part"}   # bail out        storage.write(slot, p)    storage.finalize(slot)    return {"ok": True}
Run or narrate your approach, then ask the coach.