Code reviewHardcr-g512

Subject Timeout handlingLevel Senior–Staff~18 minCommon in Code quality & review interviewsIndustries Software development, Technology

Question

Review this Go handler. The incoming request has a deadline on `r.Context()`, but the DB call ignores it.

What a strong answer looks like

Separate real bugs from style. Rank issues by severity, point at the root cause rather than the symptom, and suggest a concrete fix — specific and kind.

Learn the concepts

Talk through your review

Code to reviewgo

1func handler(w http.ResponseWriter, r *http.Request) {2    rows, err := db.QueryContext(context.Background(), heavyQuery)3    if err != nil {4        http.Error(w, "error", 500); return5    }6    defer rows.Close()7    // ... stream rows to w ...8}

Run or narrate your approach, then ask the coach.