Code reviewMediumcr-g513

Subject Swallowed exceptionsLevel Senior~16 minCommon in Code quality & review interviewsIndustries Software development, Technology

Question

Review this Java method that reads a per-user spending limit from a remote config service.

What a strong answer looks like

Separate real bugs from style. Rank issues by severity, point at the root cause rather than the symptom, and suggest a concrete fix — specific and kind.

Learn the concepts

Talk through your review

Code to reviewjava

1int limitFor(String userId) {2    try {3        return configService.getLimit(userId);4    } catch (Exception e) {5        log.warn("limit lookup failed for {}", userId);6        return DEFAULT_LIMIT; // 1000007    }8}

Run or narrate your approach, then ask the coach.