Code RoomConfig lookup swallows exceptions

MediumPrep Room Coding #2138

Config lookup swallows exceptions

Code reviewCode quality & reviewSenior~16 min

Review this Java method that reads a per-user spending limit from a remote config service.

What a strong answer looks like

Separate real bugs from style. Rank issues by severity, point at the root cause rather than the symptom, and suggest a concrete fix, specific and kind.

0:00 of about 16 min

Mark a line and say what kind of problem it is.0 findings

1int limitFor(String userId) {

2 try {

3 return configService.getLimit(userId);

4 } catch (Exception e) {

5 log.warn("limit lookup failed for {}", userId);

6 return DEFAULT_LIMIT; // 100000

7 }

8}

Which questions mattered is sealed until you submit. Telling you now would just be handing over the edge cases.