Code RoomMessage committed before processing
HardPrep Room Coding #2139

Message committed before processing

Code reviewNetworking & APIsSenior–Staff~18 min

Review this JavaScript Kafka-style consumer. It should not lose or double-process messages.

What a strong answer looks like

Separate real bugs from style. Rank issues by severity, point at the root cause rather than the symptom, and suggest a concrete fix, specific and kind.

0:00 of about 18 min
Mark a line and say what kind of problem it is.0 findings
1consumer.on('message', async (msg) => {
2 await consumer.commitOffset(msg); // mark consumed
3 await processPayment(msg.value); // do the work
4});
Which questions mattered is sealed until you submit. Telling you now would just be handing over the edge cases.