Prep Room
Sign inCreate account
Code Room
Code reviewMediumcr-g531
Subject Code reviewLevel Mid–Senior~18 minCommon in Code quality & review interviewsIndustries Software development

Question

Review this Python function that parses a batch of config files.

What a strong answer looks like

Separate real bugs from style. Rank issues by severity, point at the root cause rather than the symptom, and suggest a concrete fix — specific and kind.

Learn the concepts
Talk through your review
Code to reviewpython
def load_configs(paths):    results = []    for path in paths:        f = open(path, "r")        data = json.load(f)        results.append(validate(data))        f.close()    return results
Run or narrate your approach, then ask the coach.