Code reviewMediumcr-g533

Subject Code reviewLevel Mid–Senior~16 minCommon in Code quality & review interviewsIndustries Software development

Question

Review this Java method that deduplicates and looks up users by a money threshold.

What a strong answer looks like

Separate real bugs from style. Rank issues by severity, point at the root cause rather than the symptom, and suggest a concrete fix — specific and kind.

Learn the concepts

Talk through your review

Code to reviewjava

1Map<BigDecimal, User> byBalance = new HashMap<>();2 3void index(List<User> users) {4    for (User u : users) {5        byBalance.put(u.getBalance(), u);6    }7}8 9User exactlyTen() {10    return byBalance.get(new BigDecimal("10.0"));11}

Run or narrate your approach, then ask the coach.