Code reviewHardcr-g537

Subject Code reviewLevel Senior–Staff~22 minCommon in Networking & APIs interviewsIndustries Software development, Technology

Question

Review this Node consumer that processes payment events from an at-least-once queue.

What a strong answer looks like

Separate real bugs from style. Rank issues by severity, point at the root cause rather than the symptom, and suggest a concrete fix — specific and kind.

Learn the concepts

Talk through your review

Code to reviewjs

1async function handle(msg) {2  const { paymentId, amount, userId } = JSON.parse(msg.body);3  await db.query(4    "UPDATE accounts SET balance = balance + $1 WHERE id = $2",5    [amount, userId]6  );7  await ledger.insert({ paymentId, amount, userId });8  await msg.ack();9}

Run or narrate your approach, then ask the coach.