Code reviewMediumcr-g541

Subject Code reviewLevel Mid–Senior~16 minCommon in Code quality & review interviewsIndustries Software development

Question

Review this Java login handler's logging.

What a strong answer looks like

Separate real bugs from style. Rank issues by severity, point at the root cause rather than the symptom, and suggest a concrete fix — specific and kind.

Learn the concepts

Talk through your review

Code to reviewjava

1Response login(LoginRequest req) {2    log.info("Login attempt: {}", req);  // req.toString() includes all fields3    User u = userService.authenticate(req.getEmail(), req.getPassword());4    if (u == null) {5        log.warn("Failed login for {} with password {}", req.getEmail(), req.getPassword());6        return Response.unauthorized();7    }8    log.info("Issued token {} for {}", u.getSessionToken(), u.getEmail());9    return Response.ok(u.getSessionToken());10}

Run or narrate your approach, then ask the coach.