Serializer N+1 queries
Review this Python/Django-style serializer that builds an order summary.
What a strong answer looks like
Separate real bugs from style. Rank issues by severity, point at the root cause rather than the symptom, and suggest a concrete fix, specific and kind.
0:00 of about 18 min
Mark a line and say what kind of problem it is.0 findings
1def order_summary(order_ids):
2 out = []
3 for oid in order_ids:
4 order = Order.objects.get(id=oid)
5 lines = []
6 for item in order.items.all():
7 lines.append({
8 "product": item.product.name,
9 "price": item.product.price,
10 })
11 out.append({"order": order.id, "lines": lines})
12 return out
Which questions mattered is sealed until you submit. Telling you now would just be handing over the edge cases.
Run or narrate your approach, then ask the coach.