Code reviewMediumcr-g545

Subject Code reviewLevel Mid–Senior~16 minCommon in Code quality & review interviewsIndustries Software development

Question

Review this Java method that evicts expired sessions from a shared map.

What a strong answer looks like

Separate real bugs from style. Rank issues by severity, point at the root cause rather than the symptom, and suggest a concrete fix — specific and kind.

Learn the concepts

Talk through your review

Code to reviewjava

1void evictExpired(Map<String, Session> sessions, long nowMs) {2    for (Map.Entry<String, Session> e : sessions.entrySet()) {3        if (e.getValue().expiresAt < nowMs) {4            sessions.remove(e.getKey());5        }6    }7}

Run or narrate your approach, then ask the coach.