Code RoomWorker ignores stop flag
HardPrep Room Coding #2209

Worker ignores stop flag

Code reviewConcurrencySenior–Staff~30 min

Review this Java background worker that's stopped by a flag.

What a strong answer looks like

Separate real bugs from style. Rank issues by severity, point at the root cause rather than the symptom, and suggest a concrete fix, specific and kind.

0:00 of about 30 min
Mark a line and say what kind of problem it is.0 findings
1class Worker implements Runnable {
2 private boolean running = true;
3 
4 public void stop() { running = false; }
5 
6 public void run() {
7 while (running) {
8 process();
9 }
10 cleanup();
11 }
12}
Which questions mattered is sealed until you submit. Telling you now would just be handing over the edge cases.