Code reviewMediumcr-g587

Subject Concurrency iterate while modifyLevel Mid–Senior~24 minCommon in Concurrency interviewsIndustries Software development

Question

Review this TypeScript in-memory session store with periodic cleanup.

What a strong answer looks like

Separate real bugs from style. Rank issues by severity, point at the root cause rather than the symptom, and suggest a concrete fix — specific and kind.

Learn the concepts

Talk through your review

Code to reviewts

1const sessions = new Map<string, Session>();2 3async function reap() {4  for (const [id, s] of sessions) {5    if (s.expired()) {6      await persistToDisk(s);   // async flush before eviction7      sessions.delete(id);8    }9  }10}11setInterval(reap, 1000);

Run or narrate your approach, then ask the coach.