Code reviewHardcr-g595

Subject Http unbounded readLevel Senior–Staff~20 minCommon in Networking & APIs interviewsIndustries Software development, Technology

Question

Review this Node.js handler that proxies a file from an upstream URL into memory.

What a strong answer looks like

Separate real bugs from style. Rank issues by severity, point at the root cause rather than the symptom, and suggest a concrete fix — specific and kind.

Learn the concepts

Talk through your review

Code to reviewjs

1const https = require('https');2 3function download(url) {4  return new Promise((resolve, reject) => {5    https.get(url, (res) => {6      const chunks = [];7      res.on('data', (c) => chunks.push(c));8      res.on('end', () => resolve(Buffer.concat(chunks)));9      res.on('error', reject);10    });11  });12}

Run or narrate your approach, then ask the coach.