Code reviewMediumcr-g596

Subject Dns lookup hot loopLevel Mid–Senior~18 minCommon in Networking & APIs interviewsIndustries Software development, Technology

Question

Review this Go worker that sends one metric per loop iteration.

What a strong answer looks like

Separate real bugs from style. Rank issues by severity, point at the root cause rather than the symptom, and suggest a concrete fix — specific and kind.

Learn the concepts

Talk through your review

Code to reviewgo

1func shipMetrics(metrics <-chan Metric) {2	for m := range metrics {3		addr, _ := net.ResolveUDPAddr("udp", "metrics.internal:8125")4		conn, _ := net.DialUDP("udp", nil, addr)5		conn.Write(encode(m))6		conn.Close()7	}8}

Run or narrate your approach, then ask the coach.