Code RoomDNS lookup in hot loop

MediumPrep Room Coding #2220

DNS lookup in hot loop

Code reviewNetworking & APIsMid–Senior~18 min

Review this Go worker that sends one metric per loop iteration.

What a strong answer looks like

Separate real bugs from style. Rank issues by severity, point at the root cause rather than the symptom, and suggest a concrete fix, specific and kind.

0:00 of about 18 min

Mark a line and say what kind of problem it is.0 findings

1func shipMetrics(metrics <-chan Metric) {

2 for m := range metrics {

3 addr, _ := net.ResolveUDPAddr("udp", "metrics.internal:8125")

4 conn, _ := net.DialUDP("udp", nil, addr)

5 conn.Write(encode(m))

6 conn.Close()

7 }

8}

Which questions mattered is sealed until you submit. Telling you now would just be handing over the edge cases.