Code RoomError status ignored

EasyPrep Room Coding #2221

Error status ignored

Code reviewNetworking & APIsCode quality & reviewMid–Senior~14 min

Review this Python function that posts an order to an API.

What a strong answer looks like

Separate real bugs from style. Rank issues by severity, point at the root cause rather than the symptom, and suggest a concrete fix, specific and kind.

0:00 of about 14 min

Mark a line and say what kind of problem it is.0 findings

1import requests, json

2

3def submit_order(order):

4 resp = requests.post(

5 "https://orders.internal/api/orders",

6 json=order,

7 timeout=10,

8 )

9 return json.loads(resp.text)

Which questions mattered is sealed until you submit. Telling you now would just be handing over the edge cases.