Code reviewMediumcr-g598

Subject Tls socket no shutdownLevel Mid–Senior~18 minCommon in Networking & APIs interviewsIndustries Software development, Telecom

Question

Review this Rust function that talks to a service over a TCP stream.

What a strong answer looks like

Separate real bugs from style. Rank issues by severity, point at the root cause rather than the symptom, and suggest a concrete fix — specific and kind.

Learn the concepts

Talk through your review

Code to reviewrust

1use std::net::TcpStream;2use std::io::{Write, Read};3 4fn rpc(req: &[u8]) -> std::io::Result<Vec<u8>> {5    let mut s = TcpStream::connect("svc.internal:9000")?;6    s.write_all(req)?;7    let mut buf = Vec::new();8    s.read_to_end(&mut buf)?;9    Ok(buf)10}

Run or narrate your approach, then ask the coach.