Code RoomSocket not shut down

MediumPrep Room Coding #2222

Socket not shut down

Code reviewNetworking & APIsMid–Senior~18 min

Review this Rust function that talks to a service over a TCP stream.

What a strong answer looks like

Separate real bugs from style. Rank issues by severity, point at the root cause rather than the symptom, and suggest a concrete fix, specific and kind.

0:00 of about 18 min

Mark a line and say what kind of problem it is.0 findings

1use std::net::TcpStream;

2use std::io::{Write, Read};

3

4fn rpc(req: &[u8]) -> std::io::Result<Vec<u8>> {

5 let mut s = TcpStream::connect("svc.internal:9000")?;

6 s.write_all(req)?;

7 let mut buf = Vec::new();

8 s.read_to_end(&mut buf)?;

9 Ok(buf)

10}

Which questions mattered is sealed until you submit. Telling you now would just be handing over the edge cases.