RPC call never times out

Code reviewNetworking & APIsSenior–Staff~20 min

Review this Go gRPC call inside an HTTP request handler.

What a strong answer looks like

Separate real bugs from style. Rank issues by severity, point at the root cause rather than the symptom, and suggest a concrete fix, specific and kind.

0:00 of about 20 min

Mark a line and say what kind of problem it is.0 findings

1func handler(w http.ResponseWriter, r *http.Request) {

2 res, err := inventoryClient.Reserve(context.Background(), &pb.ReserveReq{Sku: r.FormValue("sku")})

3 if err != nil {

4 http.Error(w, err.Error(), 500)

5 return

6 }

7 fmt.Fprint(w, res.Token)

Which questions mattered is sealed until you submit. Telling you now would just be handing over the edge cases.