Code RoomPagination not followed
HardPrep Room Coding #2228

Pagination not followed

Code reviewNetworking & APIsDistributed systemsSenior–Staff~22 min

Review this Go code that streams and aggregates a paged API response.

What a strong answer looks like

Separate real bugs from style. Rank issues by severity, point at the root cause rather than the symptom, and suggest a concrete fix, specific and kind.

0:00 of about 22 min
Mark a line and say what kind of problem it is.0 findings
1func loadAll(url string) ([]Item, error) {
2 resp, err := http.Get(url)
3 if err != nil {
4 return nil, err
5 }
6 defer resp.Body.Close()
7 dec := json.NewDecoder(resp.Body)
8 var page Page
9 dec.Decode(&page)
10 return page.Items, nil
11}
Which questions mattered is sealed until you submit. Telling you now would just be handing over the edge cases.