Code reviewHardcr-g606

Subject Storage durabilityLevel Senior–Staff~22 minCommon in Storage & CDN · Concurrency interviewsIndustries Software development, Technology

Question

Review this Go function that persists config and reports success.

What a strong answer looks like

Separate real bugs from style. Rank issues by severity, point at the root cause rather than the symptom, and suggest a concrete fix — specific and kind.

Learn the concepts

Talk through your review

Code to reviewgo

1func SaveConfig(path string, cfg *Config) error {2    f, err := os.Create(path)3    if err != nil {4        return err5    }6    defer f.Close()7    enc := json.NewEncoder(f)8    if err := enc.Encode(cfg); err != nil {9        return err10    }11    log.Printf("config saved durably to %s", path)12    return nil13}

Run or narrate your approach, then ask the coach.