Cache grows without bound

Code reviewStorage & CDNMid–Senior~18 min

Review this Python on-disk-blob cache wrapper.

What a strong answer looks like

Separate real bugs from style. Rank issues by severity, point at the root cause rather than the symptom, and suggest a concrete fix, specific and kind.

0:00 of about 18 min

Mark a line and say what kind of problem it is.0 findings

1class ThumbnailCache:

2 def __init__(self):

3 self._cache = {} # image_id -> bytes

5 def get(self, image_id, render):

6 if image_id in self._cache:

7 return self._cache[image_id]

8 data = render(image_id) # decodes + resizes, ~200KB-2MB each

9 self._cache[image_id] = data

10 return data

Which questions mattered is sealed until you submit. Telling you now would just be handing over the edge cases.