Code reviewMediumcr-g609

Subject Storage cache evictionLevel Mid–Senior~18 minCommon in Storage & CDN interviewsIndustries Software development

Question

Review this Python on-disk-blob cache wrapper.

What a strong answer looks like

Separate real bugs from style. Rank issues by severity, point at the root cause rather than the symptom, and suggest a concrete fix — specific and kind.

Learn the concepts

Talk through your review

Code to reviewpython

1class ThumbnailCache:2    def __init__(self):3        self._cache = {}          # image_id -> bytes4 5    def get(self, image_id, render):6        if image_id in self._cache:7            return self._cache[image_id]8        data = render(image_id)   # decodes + resizes, ~200KB-2MB each9        self._cache[image_id] = data10        return data

Run or narrate your approach, then ask the coach.