Code reviewHardcr-g612

Subject Storage toctouLevel Senior–Staff~22 minCommon in Security · Storage & CDN interviewsIndustries Software development

Question

Review this Go handler that serves user files.

What a strong answer looks like

Separate real bugs from style. Rank issues by severity, point at the root cause rather than the symptom, and suggest a concrete fix — specific and kind.

Learn the concepts

Talk through your review

Code to reviewgo

1func serveTempFile(w http.ResponseWriter, name string) error {2    path := filepath.Join("/var/tmp/exports", name)3    info, err := os.Stat(path)4    if err != nil {5        return err6    }7    if info.Size() > maxExportBytes {8        return errTooLarge9    }10    data, err := os.ReadFile(path)   // open + read after the stat11    if err != nil {12        return err13    }14    _, err = w.Write(data)15    return err16}

Run or narrate your approach, then ask the coach.