Code RoomLarge upload not multipart
HardPrep Room Coding #2238

Large upload not multipart

Code reviewStorage & CDNSenior–Staff~22 min

Review this Rust function uploading a large object to blob storage.

What a strong answer looks like

Separate real bugs from style. Rank issues by severity, point at the root cause rather than the symptom, and suggest a concrete fix, specific and kind.

0:00 of about 22 min
Mark a line and say what kind of problem it is.0 findings
1async fn upload_blob(client: &BlobClient, container: &str, name: &str, path: &Path) -> Result<()> {
2 let bytes = tokio::fs::read(path).await?; // files routinely 1-20 GB
3 client
4 .container(container)
5 .blob(name)
6 .put_block_blob(bytes) // single request
7 .await?;
8 Ok(())
9}
Which questions mattered is sealed until you submit. Telling you now would just be handing over the edge cases.