Large download buffered in memory

Code reviewStorage & CDNDistributed systemsMid–Senior~18 min

Review this Node endpoint that proxies a file download.

What a strong answer looks like

Separate real bugs from style. Rank issues by severity, point at the root cause rather than the symptom, and suggest a concrete fix, specific and kind.

0:00 of about 18 min

Mark a line and say what kind of problem it is.0 findings

1app.get("/files/:id", async (req, res) => {

2 const obj = await s3.getObject({ Bucket: BK, Key: req.params.id }).promise();

3 const body = obj.Body; // entire object buffered in memory

4 res.setHeader("Content-Type", obj.ContentType);

5 res.setHeader("Content-Length", body.length);

6 res.send(body);

7});

Which questions mattered is sealed until you submit. Telling you now would just be handing over the edge cases.