Code reviewMediumcr-g615

Subject Storage streaming downloadLevel Mid–Senior~18 minCommon in Storage & CDN · Distributed systems interviewsIndustries Software development, Technology

Question

Review this Node endpoint that proxies a file download.

What a strong answer looks like

Separate real bugs from style. Rank issues by severity, point at the root cause rather than the symptom, and suggest a concrete fix — specific and kind.

Learn the concepts

Talk through your review

Code to reviewjs

1app.get("/files/:id", async (req, res) => {2  const obj = await s3.getObject({ Bucket: BK, Key: req.params.id }).promise();3  const body = obj.Body;          // entire object buffered in memory4  res.setHeader("Content-Type", obj.ContentType);5  res.setHeader("Content-Length", body.length);6  res.send(body);7});

Run or narrate your approach, then ask the coach.