Code RoomNon-atomic state file write

MediumPrep Room Coding #2240

Non-atomic state file write

Code reviewStorage & CDNConcurrencyMid–Senior~18 min

Review this Python function that updates a state file consumed by another process.

What a strong answer looks like

Separate real bugs from style. Rank issues by severity, point at the root cause rather than the symptom, and suggest a concrete fix, specific and kind.

0:00 of about 18 min

Mark a line and say what kind of problem it is.0 findings

1import json

2

3def write_state(path, state):

4 with open(path, "w") as f:

5 for key, value in state.items():

6 f.write(json.dumps({key: value}) + "\n")

7 return True

Which questions mattered is sealed until you submit. Telling you now would just be handing over the edge cases.