Code Room
Code reviewMedium
Question
Review this Java method that counts matching lines in a log file.
What a strong answer looks like
Separate real bugs from style. Rank issues by severity, point at the root cause rather than the symptom, and suggest a concrete fix — specific and kind.
Learn the concepts
public long countMatches(Path logFile, String needle) throws IOException { List<String> lines = Files.readAllLines(logFile); // multi-GB logs long count = 0; for (String line : lines) { if (line.contains(needle)) { count++; } } return count;}Run or narrate your approach, then ask the coach.