Large file loaded into memory
Review this Java method that counts matching lines in a log file.
What a strong answer looks like
Separate real bugs from style. Rank issues by severity, point at the root cause rather than the symptom, and suggest a concrete fix, specific and kind.
0:00 of about 18 min
Mark a line and say what kind of problem it is.0 findings
1public long countMatches(Path logFile, String needle) throws IOException {
2 List<String> lines = Files.readAllLines(logFile); // multi-GB logs
3 long count = 0;
4 for (String line : lines) {
5 if (line.contains(needle)) {
6 count++;
7 }
8 }
9 return count;
10}
Which questions mattered is sealed until you submit. Telling you now would just be handing over the edge cases.
Run or narrate your approach, then ask the coach.