Code reviewMediumcr-g641

Subject Connection pool leakLevel Mid–Senior~20 minCommon in Code quality & review interviewsIndustries Software development

Question

Review this Node.js function using a node-postgres pool.

What a strong answer looks like

Separate real bugs from style. Rank issues by severity, point at the root cause rather than the symptom, and suggest a concrete fix — specific and kind.

Learn the concepts

Talk through your review

Code to reviewjs

1async function getProfile(pool, userId) {2  const client = await pool.connect();3  const { rows } = await client.query(4    'SELECT * FROM profiles WHERE user_id = $1',5    [userId]6  );7  if (rows.length === 0) {8    throw new NotFoundError('no profile');9  }10  client.release();11  return rows[0];12}

Run or narrate your approach, then ask the coach.