Code RoomConnection not released on exception
MediumPrep Room Coding #2265

Connection not released on exception

Code reviewCode quality & reviewMid–Senior~20 min

Review this Node.js function using a node-postgres pool.

What a strong answer looks like

Separate real bugs from style. Rank issues by severity, point at the root cause rather than the symptom, and suggest a concrete fix, specific and kind.

0:00 of about 20 min
Mark a line and say what kind of problem it is.0 findings
1async function getProfile(pool, userId) {
2 const client = await pool.connect();
3 const { rows } = await client.query(
4 'SELECT * FROM profiles WHERE user_id = $1',
5 [userId]
6 );
7 if (rows.length === 0) {
8 throw new NotFoundError('no profile');
9 }
10 client.release();
11 return rows[0];
12}
Which questions mattered is sealed until you submit. Telling you now would just be handing over the edge cases.