Code reviewEasycr-p001

Subject CorrectnessLevel Mid–Senior~18 minCommon in Code quality & review interviewsIndustries Software development

Question

Review this helper meant to return events from the last n days. What do you flag?

What a strong answer looks like

Separate real bugs from style. Rank issues by severity, point at the root cause rather than the symptom, and suggest a concrete fix — specific and kind.

Learn the concepts

Talk through your review

Code to reviewpython

1def last_n_days(events, n):2    cutoff = now() - timedelta(days=n)3    return [e for e in events if e.timestamp > cutoff]

Run or narrate your approach, then ask the coach.