Code reviewMediumcr-p005

Subject PerformanceLevel Mid–Senior~18 minCommon in Code quality & review interviewsIndustries Software development

Question

Review this code that builds an order summary.

What a strong answer looks like

Separate real bugs from style. Rank issues by severity, point at the root cause rather than the symptom, and suggest a concrete fix — specific and kind.

Learn the concepts

Talk through your review

Code to reviewpython

1orders = Order.where(user_id=uid)2result = []3for o in orders:4    items = OrderItem.where(order_id=o.id)   # query per order5    result.append({'order': o, 'items': items})

Run or narrate your approach, then ask the coach.