Code RoomMissing user returns 200

MediumPrep Room Coding #2283

Missing user returns 200

Code reviewNetworking & APIsMid–Senior~18 min

Review this API change. The endpoint used to return 404 for a missing user; the PR changes it to:

What a strong answer looks like

Separate real bugs from style. Rank issues by severity, point at the root cause rather than the symptom, and suggest a concrete fix, specific and kind.

0:00 of about 18 min

Mark a line and say what kind of problem it is.0 findings

1def get_user(id):

2 u = User.get(id)

3 if not u:

4 return {'error': 'not found'}, 200

5 return u, 200

Which questions mattered is sealed until you submit. Telling you now would just be handing over the edge cases.