Code reviewMediumcr-p011

Subject Test coverageLevel Mid–Senior~18 minCommon in Code quality & review interviewsIndustries Software development

Question

Review this unit test.

What a strong answer looks like

Separate real bugs from style. Rank issues by severity, point at the root cause rather than the symptom, and suggest a concrete fix — specific and kind.

Learn the concepts

Talk through your review

Code to reviewpython

1def test_create_user():2    svc = UserService(db=Mock())3    svc.create('a@b.com')4    assert svc.db.insert.called

Run or narrate your approach, then ask the coach.