Code reviewMediumcr-p018

Subject PerformanceLevel Senior–Staff~18 minCommon in Code quality & review interviewsIndustries Software development

Question

Review this export endpoint.

What a strong answer looks like

Separate real bugs from style. Rank issues by severity, point at the root cause rather than the symptom, and suggest a concrete fix — specific and kind.

Learn the concepts

Talk through your review

Code to reviewpython

1def export_all():2    rows = db.query('SELECT * FROM events')3    return json.dumps([r.to_dict() for r in rows])

Run or narrate your approach, then ask the coach.