Code reviewHardcr-p022

Subject Error handlingLevel Senior–Staff~18 minCommon in Code quality & review interviewsIndustries Software development

Question

Review this retry loop calling a payment provider.

What a strong answer looks like

Separate real bugs from style. Rank issues by severity, point at the root cause rather than the symptom, and suggest a concrete fix — specific and kind.

Learn the concepts

Talk through your review

Code to reviewpython

1for _ in range(5):2    resp = provider.charge(card, amount)3    if resp.ok:4        break

Run or narrate your approach, then ask the coach.