Code reviewMediumcr-p023

Subject CorrectnessLevel Mid–Senior~18 minCommon in Code quality & review interviewsIndustries Software development

Question

Review this code that decides if a subscription expired.

What a strong answer looks like

Separate real bugs from style. Rank issues by severity, point at the root cause rather than the symptom, and suggest a concrete fix — specific and kind.

Learn the concepts

Talk through your review

Code to reviewpython

1def expired(sub):2    return datetime.now() > sub.expires_at

Run or narrate your approach, then ask the coach.