Code RoomSingleton initialization not thread-safe

HardPrep Room Coding #2300

Singleton initialization not thread-safe

Code reviewConcurrencySenior~18 min

Review this lazily-initialized singleton used from multiple threads.

What a strong answer looks like

Separate real bugs from style. Rank issues by severity, point at the root cause rather than the symptom, and suggest a concrete fix, specific and kind.

0:00 of about 18 min

Mark a line and say what kind of problem it is.0 findings

1_instance = None

2

3def get_instance():

4 global _instance

5 if _instance is None:

6 _instance = ExpensiveClient()

7 return _instance

Which questions mattered is sealed until you submit. Telling you now would just be handing over the edge cases.