Code reviewMediumcr-p027

Subject SecurityLevel Mid–Senior~18 minCommon in Security interviewsIndustries Software development

Question

Review this file-download handler.

What a strong answer looks like

Separate real bugs from style. Rank issues by severity, point at the root cause rather than the symptom, and suggest a concrete fix — specific and kind.

Learn the concepts

Talk through your review

Code to reviewpython

1@app.get('/files')2def serve():3    name = request.args['name']4    return open(os.path.join('/var/data', name)).read()

Run or narrate your approach, then ask the coach.