Prep Room
Sign inCreate account
Code Room
Code reviewMediumcr-p028
Subject CorrectnessLevel Mid–Senior~18 minCommon in Code quality & review interviewsIndustries Software development

Question

Review this function that sums a possibly deeply-nested list.

What a strong answer looks like

Separate real bugs from style. Rank issues by severity, point at the root cause rather than the symptom, and suggest a concrete fix — specific and kind.

Learn the concepts
Talk through your review
Code to reviewpython
def deep_sum(items):    total = 0    for x in items:        if isinstance(x, list):            total += deep_sum(x)        else:            total += x    return total
Run or narrate your approach, then ask the coach.