Code reviewHardcr-p042

Subject SecurityLevel Senior~18 minCommon in Security interviewsIndustries Software development

Question

Review this login check.

What a strong answer looks like

Separate real bugs from style. Rank issues by severity, point at the root cause rather than the symptom, and suggest a concrete fix — specific and kind.

Learn the concepts

Talk through your review

Code to reviewpython

1def check(stored_hash, password):2    return stored_hash == hashlib.md5(password.encode()).hexdigest()

Run or narrate your approach, then ask the coach.