Code RoomCache hit skips lock

HardPrep Room Coding #2318

Cache hit skips lock

Code reviewConcurrencyCode quality & reviewSenior~18 min

An AI generated this 'thread-safe' memoization cache. Review it.

What a strong answer looks like

Separate real bugs from style. Rank issues by severity, point at the root cause rather than the symptom, and suggest a concrete fix, specific and kind.

0:00 of about 18 min

Mark a line and say what kind of problem it is.0 findings

1_cache = {}

2_lock = threading.Lock()

3

4def get(key):

5 if key in _cache:

6 return _cache[key]

7 with _lock:

8 _cache[key] = compute(key)

9 return _cache[key]

Which questions mattered is sealed until you submit. Telling you now would just be handing over the edge cases.