Code RoomFile conversion allows command injection
HardPrep Room Coding #2323

File conversion allows command injection

Code reviewSecuritySenior~18 min

Review this code that converts an uploaded file.

What a strong answer looks like

Separate real bugs from style. Rank issues by severity, point at the root cause rather than the symptom, and suggest a concrete fix, specific and kind.

0:00 of about 18 min
Mark a line and say what kind of problem it is.0 findings
1import os
2def to_pdf(filename):
3 os.system('libreoffice --convert-to pdf ' + filename)
Which questions mattered is sealed until you submit. Telling you now would just be handing over the edge cases.