Code RoomRate limit check non-atomic
MediumPrep Room Coding #2335

Rate limit check non-atomic

Code reviewConcurrencySenior~18 min

Review this rate-limit check.

What a strong answer looks like

Separate real bugs from style. Rank issues by severity, point at the root cause rather than the symptom, and suggest a concrete fix, specific and kind.

0:00 of about 18 min
Mark a line and say what kind of problem it is.0 findings
1count = store.get(key) or 0
2if count >= LIMIT:
3 return reject()
4store.set(key, count + 1)
5return allow()
Which questions mattered is sealed until you submit. Telling you now would just be handing over the edge cases.