Code reviewMediumcr-p084

Subject CorrectnessLevel Mid–Senior~18 minCommon in Code quality & review interviewsIndustries Software development

Question

Review this code that returns the 'first' matching config.

What a strong answer looks like

Separate real bugs from style. Rank issues by severity, point at the root cause rather than the symptom, and suggest a concrete fix — specific and kind.

Learn the concepts

Talk through your review

Code to reviewpython

1def first_match(configs, predicate):2    matches = {c.id for c in configs if predicate(c)}3    return next(iter(matches))

Run or narrate your approach, then ask the coach.