Code RoomWindow reset loses requests

HardPrep Room Coding #2378

Window reset loses requests

Code reviewConcurrencyCode quality & reviewSenior~18 min

An AI generated this fixed-window rate limiter. Review it.

What a strong answer looks like

Separate real bugs from style. Rank issues by severity, point at the root cause rather than the symptom, and suggest a concrete fix, specific and kind.

0:00 of about 18 min

Mark a line and say what kind of problem it is.0 findings

1def allow(user, now):

2 bucket = windows.setdefault(user, {'start': now, 'count': 0})

3 if now - bucket['start'] > 60:

4 bucket['count'] = 0

5 bucket['count'] += 1

6 return bucket['count'] <= LIMIT

Which questions mattered is sealed until you submit. Telling you now would just be handing over the edge cases.